Add check to accomodate move away from _FillValue in libnetcdf #1994
Conversation
|
@WardF thanks - I'll have a look at the github testing tomorrow. |
| #if defined(NC_FillValue) | ||
| #define NCDF_FillValue NC_FillValue | ||
| #elif defined(_FillValue) | ||
| #define NCDF_Fillvalue _FillValue |
There was a problem hiding this comment.
I think instead of introducing a third macro, just define NC_FillValue if not defined and use that everywhere.
There was a problem hiding this comment.
@WardF I've made the change suggested by @edwardhartnett can you give me permission to push back to your fork?
There was a problem hiding this comment.
@jedwards4b sorry for the radio silence, I've been at an NSF Unidata retreat for the last couple of days. I'll modify that permission!
There was a problem hiding this comment.
@jedwards4b The 'allow edits by maintainers' option is selected, does this not give you access to push changes to this PR? If not, maybe it would be easier (and certainly no problem from my end) to pull the changes I've proposed into a new PR that you can push and merge?
|
superseded by #1995 |
Adopted from the approach taken by
GDALto address the same issue see reference here. This will allowParallelIOto compile without having to worry about changing any workflows around the--enable-legacy-macrosflag being introduced in v4.9.3.